Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing regtest prefix in address check #5109

Merged
merged 8 commits into from
Mar 25, 2024
Merged

fix: missing regtest prefix in address check #5109

merged 8 commits into from
Mar 25, 2024

Conversation

kyranjamie
Copy link
Collaborator

@kyranjamie kyranjamie commented Mar 20, 2024 •
edited by leather-bot
Loading

Try out Leather build bae5ff6 — Extension build, Test report, Storybook, Chromatic

cc @Polybius93

This doesn't fix #5076 yet, but I did find some regtest errors in investigating

@kyranjamie kyranjamie requested a review from fbwoolf March 20, 2024 17:42
@kyranjamie kyranjamie marked this pull request as ready for review March 20, 2024 17:42
@kyranjamie kyranjamie force-pushed the fix/regtest-addresses branch from b1085d9 to 4371b84 Compare March 20, 2024 17:42
@kyranjamie kyranjamie force-pushed the fix/regtest-addresses branch from 3ef69dc to bae5ff6 Compare March 24, 2024 17:13
@kyranjamie kyranjamie added this pull request to the merge queue Mar 25, 2024
Merged via the queue into dev with commit 7ec9744 Mar 25, 2024
30 checks passed
@kyranjamie kyranjamie deleted the fix/regtest-addresses branch March 25, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbwoolf fbwoolf fbwoolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signing PSBT with multiple inputs provides errors
3 participants
@kyranjamie @fbwoolf @Polybius93